Skip to content

Tests: Import: AWeber #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n7studios merged 9 commits into from
Jan 15, 2026
Merged

Tests: Import: AWeber #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b197209
Integration Tests
n7studios Jan 13, 2026
b429e8a
Tests: Import: AWeber
n7studios Jan 13, 2026
d9ce0d3
Merge branch 'migrate-aweber' into migrate-aweber-tests
n7studios Jan 13, 2026
2063985
Added Tests
n7studios Jan 13, 2026
06a3bbf
Reinstate headless mode
n7studios Jan 13, 2026
81eedd7
Tests: Removed third party plugin activation/deactivation
n7studios Jan 13, 2026
d344c66
Coding standards
n7studios Jan 13, 2026
d077e2a
Merge branch 'migrate-aweber' into migrate-aweber-tests
n7studios Jan 15, 2026
9df7214
Improve and clarify FromContent tests
n7studios Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 198 additions & 0 deletions tests/EndToEnd/general/plugin-screens/PluginSettingsToolsImporterAweberCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,198 @@
<?php

namespace Tests\EndToEnd;

use Tests\Support\EndToEndTester;

/**
* Tests for the Settings > Kit > Tools > Import sections for AWeber.
*
* @since 3.1.5
*/
class PluginSettingsToolsImporterAweberCest
{
/**
* Run common actions before running the test functions in this class.
*
* @since 3.1.5
*
* @param EndToEndTester $I Tester.
*/
public function _before(EndToEndTester $I)
{
// Activate Plugins.
$I->activateKitPlugin($I);
}

/**
* Test that AWeber Forms are replaced with Kit Forms when the Tools > AWeber: Migrate Configuration is configured.
*
* @since 3.1.5
*
* @param EndToEndTester $I Tester.
*/
public function testAWeberImport(EndToEndTester $I)
{
// Setup Plugin.
$I->setupKitPlugin($I);
$I->setupKitPluginResources($I);

// Create Aweber Forms.
$aweberFormIDs = $this->_createAWeberForms($I);

// Insert AWeber Form Shortcodes into Pages.
$pageIDs = $this->_createPagesWithAWeberFormShortcodes($I, $aweberFormIDs);

// Navigate to the Tools screen.
$I->loadKitSettingsToolsScreen($I);

// Select the Kit Forms to replace the AWeber Forms.
foreach ($aweberFormIDs as $aweberFormID) {
$I->selectOption('_wp_convertkit_integration_aweber_settings[' . $aweberFormID . ']', $_ENV['CONVERTKIT_API_FORM_ID']);
}

// Click the Migrate button.
$I->click('Migrate');

// Confirm success message displays.
$I->waitForElementVisible('.notice-success');
$I->see('AWeber forms migrated successfully.');

// View the Pages, to confirm Kit Forms now display.
foreach ($pageIDs as $pageID) {
$I->amOnPage('?p=' . $pageID);
$I->seeElementInDOM('form[data-sv-form]');
}
}

/**
* Test that the AWeber: Migrate Configuration section is not displayed when no AWeber Forms exist.
*
* @since 3.1.5
*
* @param EndToEndTester $I Tester.
*/
public function testAWeberImportWhenNoAWeberForms(EndToEndTester $I)
{
// Setup Plugin.
$I->setupKitPlugin($I);
$I->setupKitPluginResources($I);

// Navigate to the Tools screen.
$I->loadKitSettingsToolsScreen($I);

// Confirm no AWeber: Migrate Configuration section is displayed.
$I->dontSeeElementInDOM('#import-aweber');
}

/**
* Test that the AWeber: Migrate Configuration section is not displayed when AWeber Forms exist,
* but no Pages, Posts or Custom Posts contain AWeber Form Shortcodes.
*
* @since 3.1.5
*
* @param EndToEndTester $I Tester.
*/
public function testAWeberImportWhenNoAWeberShortcodesInContent(EndToEndTester $I)
{
// Setup Plugin.
$I->setupKitPlugin($I);
$I->setupKitPluginResources($I);

// Create AWeber Forms.
$aweberFormIDs = $this->_createAWeberForms($I);

// Navigate to the Tools screen.
$I->loadKitSettingsToolsScreen($I);

// Confirm no AWeber: Migrate Configuration section is displayed, as there are no
// AWeber Form Shortcodes in the content.
$I->dontSeeElementInDOM('#import-aweber');
}

/**
* Test that the AWeber: Migrate Configuration section is not displayed when no Kit Forms exist.
*
* @since 3.1.5
*
* @param EndToEndTester $I Tester.
*/
public function testAWeberImportWhenNoKitForms(EndToEndTester $I)
{
// Setup Plugin.
$I->setupKitPluginCredentialsNoData($I);
$I->setupKitPluginResourcesNoData($I);

// Navigate to the Tools screen.
$I->loadKitSettingsToolsScreen($I);

// Confirm no AWeber: Migrate Configuration section is displayed, as there are no
// AWeber Form Shortcodes in the content.
$I->dontSeeElementInDOM('#import-aweber');
}

/**
* Create AWeber Forms.
*
* @since 3.1.5
*
* @return array
*/
private function _createAWeberForms()
{
// AWeber doesn't cache Forms or store them in the database, so we mock the data that would be returned from their API.
return [
'10',
'11',
];
}

/**
* Create Pages with AWeber Form Shortcodes.
*
* @since 3.1.5
*
* @param EndToEndTester $I Tester.
* @param array $aweberFormIDs AWeber Form IDs.
* @return array
*/
private function _createPagesWithAWeberFormShortcodes(EndToEndTester $I, $aweberFormIDs)
{
$pageIDs = array();

foreach ($aweberFormIDs as $aweberFormID) {
$pageIDs[] = $I->havePostInDatabase(
[
'post_type' => 'page',
'post_status' => 'publish',
'post_title' => 'Page with AWeber Form #' . $aweberFormID,
'post_content' => '[aweber formid="' . $aweberFormID . '"]',
'meta_input' => [
'_wp_convertkit_post_meta' => [
'form' => '0',
'landing_page' => '',
'tag' => '',
],
],
]
);
}

return $pageIDs;
}

/**
* Deactivate and reset Plugin(s) after each test, if the test passes.
* We don't use _after, as this would provide a screenshot of the Plugin
* deactivation and not the true test error.
*
* @since 3.1.5
*
* @param EndToEndTester $I Tester.
*/
public function _passed(EndToEndTester $I)
{
$I->deactivateKitPlugin($I);
$I->resetKitPlugin($I);
}
}
132 changes: 132 additions & 0 deletions tests/Integration/ImporterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,138 @@ public function tearDown(): void
parent::tearDown();
}

/**
* Test that the get_form_ids_from_content() method returns AWeber form shortcode Form IDs
* ignoring any other shortcodes.
*
* @since 3.1.5
*/
public function testGetAWeberFormIDsFromContent()
Copy link
Contributor

@noelherrick noelherrick Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you moved this to the parent class, it makes more sense to name the test at that level, so testGetGenericFormIDsFromContent vs. naming to the specific provider. I also don't see the value of testGetMC4WPFormIDsFromContent since you're exercising the same code.

Copy link
Contributor Author

@n7studios n7studios Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep these, as they test using the ConvertKit_Admin_Importer_AWeber / ConvertKit_Admin_Importer_MC4WP classes, ensuring only the applicable shortcodes are extracted i.e. AWeber shortcodes when using ConvertKit_Admin_Importer_AWeber and Mailchimp shortcodes when using `ConvertKit_Admin_Importer_MC4WP.

I've improved the tests to ensure other shortcodes aren't extracted, which hopefully means having two separate tests makes more sense here.

{
// Initialize the class we want to test.
$this->importer = new \ConvertKit_Admin_Importer_AWeber();

// Confirm initialization didn't result in an error.
$this->assertNotInstanceOf(\WP_Error::class, $this->importer);

// Define the content to test.
$content = '[aweber formid="10"] some content [aweber formid="11"] some other content [mc4wp_form id="12"] different shortcode to ignore';

// Extract form IDs from content.
$form_ids = $this->importer->get_form_ids_from_content( $content );

// Assert the correct number of form IDs are returned.
$this->assertEquals( 2, count( $form_ids ) );
$this->assertEquals( 10, $form_ids[0] );
$this->assertEquals( 11, $form_ids[1] );
}

/**
* Test that the replace_shortcodes_in_content() method replaces the third party form shortcode with the Kit form shortcode.
*
* @since 3.1.5
*/
public function testAWeberReplaceShortcodesInContent()
{
// Initialize the class we want to test.
$this->importer = new \ConvertKit_Admin_Importer_AWeber();

// Confirm initialization didn't result in an error.
$this->assertNotInstanceOf(\WP_Error::class, $this->importer);

// Define the shortcodes to test.
$shortcodes = [
'[aweber formid=10]',
'[aweber formid="10"]',
'[aweber formid=10 listid=11]',
'[aweber formid="10" listid="11"]',
'[aweber formid=10 listid=11 formtype=webform]',
'[aweber formid="10" listid="11" formtype="webform"]',
'[aweber listid=11 formid=10]',
'[aweber listid="11" formid="10"]',
'[aweber listid=11 formid=10 formtype=webform]',
'[aweber listid="11" formid="10" formtype="webform"]',
'[aweber formtype=webform listid=11 formid=10]',
'[aweber formtype="webform" listid="11" formid="10"]',
];

// Test each shortcode is replaced with the Kit form shortcode.
foreach ( $shortcodes as $shortcode ) {
$this->assertEquals(
'[convertkit_form id="' . $_ENV['CONVERTKIT_API_FORM_ID'] . '"]',
$this->importer->replace_shortcodes_in_content( $shortcode, 10, $_ENV['CONVERTKIT_API_FORM_ID'] )
);

// Prepend and append some content.
$content = 'Some content before the shortcode: ' . $shortcode . ' Some content after the shortcode.';
$this->assertEquals(
'Some content before the shortcode: [convertkit_form id="' . $_ENV['CONVERTKIT_API_FORM_ID'] . '"] Some content after the shortcode.',
$this->importer->replace_shortcodes_in_content( $content, 10, $_ENV['CONVERTKIT_API_FORM_ID'] )
);

// Prepend and append some content and duplicate the shortcode.
$content = 'Some content before the shortcode: ' . $shortcode . ' Some content after the shortcode: ' . $shortcode;
$this->assertEquals(
'Some content before the shortcode: [convertkit_form id="' . $_ENV['CONVERTKIT_API_FORM_ID'] . '"] Some content after the shortcode: [convertkit_form id="' . $_ENV['CONVERTKIT_API_FORM_ID'] . '"]',
$this->importer->replace_shortcodes_in_content( $content, 10, $_ENV['CONVERTKIT_API_FORM_ID'] )
);
}
}

/**
* Test that the replace_shortcodes_in_content() method ignores non-AWeber shortcodes.
*
* @since 3.1.5
*/
public function testAWeberReplaceShortcodesInContentIgnoringOtherShortcodes()
{
// Initialize the class we want to test.
$this->importer = new \ConvertKit_Admin_Importer_AWeber();

// Confirm initialization didn't result in an error.
$this->assertNotInstanceOf(\WP_Error::class, $this->importer);

// Define the shortcodes to test.
$shortcodes = [
'[convertkit_form id="' . $_ENV['CONVERTKIT_API_FORM_ID'] . '"]',
'[a_random_shortcode]',
];

// Test each shortcode is ignored.
foreach ( $shortcodes as $shortcode ) {
$this->assertEquals(
$shortcode,
$this->importer->replace_shortcodes_in_content( $shortcode, 10, $_ENV['CONVERTKIT_API_FORM_ID'] )
);
}
}

/**
* Test that the get_form_ids_from_content() method returns MC4WP form shortcode Form IDs
* ignoring any other shortcodes.
*
* @since 3.1.5
*/
public function testGetMC4WPFormIDsFromContent()
{
// Initialize the class we want to test.
$this->importer = new \ConvertKit_Admin_Importer_MC4WP();

// Confirm initialization didn't result in an error.
$this->assertNotInstanceOf(\WP_Error::class, $this->importer);

// Define the content to test.
$content = '[mc4wp_form id="10"] some content [mc4wp_form id="11"] some other content [aweber formid="12"] different shortcode to ignore';

// Extract form IDs from content.
$form_ids = $this->importer->get_form_ids_from_content( $content );

// Assert the correct number of form IDs are returned.
$this->assertEquals( 2, count( $form_ids ) );
$this->assertEquals( 10, $form_ids[0] );
$this->assertEquals( 11, $form_ids[1] );
}

/**
* Test that the replace_shortcodes_in_content() method replaces the third party form shortcode with the Kit form shortcode.
*
Expand Down