docs: Fix small issues on README and other documents. #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffrujeri
force-pushed
the
ffrujeri/docs-tools-fix
branch
from
71bf4e5 to
0970f5a
Compare
bxyu-nvidia
requested changes
Nov 20, 2025
| cd Gym | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| source $HOME/.local/bin/env | ||
| export PATH=$HOME/.local/bin/env/bin:$PATH # or |
Contributor
There was a problem hiding this comment.
can we avoid this temporary environment variable export? and also why did the source not work for you?
Contributor
Author
There was a problem hiding this comment.
So the issue here is that for the newest version of uv, they changed the way the tool is installed, now I don't see a $HOME/.local/bin/env anymore, instead the tool is installed as uv and uvx in /home/ffrujeri/.local/bin/
(nemo-gym) ffrujeri@40cec8e-lcedt:~/nemo-gym$ which uv
/home/ffrujeri/.local/bin/uv
| asyncio.run(rch.run_from_config(config)) | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
Contributor
There was a problem hiding this comment.
does ng_collect_rollouts not work? is the command not discoverable? why do we need this section here?
Contributor
Author
There was a problem hiding this comment.
So, the entry points for scripts is mainly when we are trying to launch debug.py I was thinking and there is no harm on also giving this entry point, is there?
Signed-off-by: Felipe Vieira Frujeri <[email protected]>
ffrujeri
force-pushed
the
ffrujeri/docs-tools-fix
branch
from
0970f5a to
058e88a
Compare
Signed-off-by: Felipe Vieira Frujeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.