-
Notifications
You must be signed in to change notification settings - Fork 5
docs: Fix small issues on README and other documents. #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,7 +65,8 @@ We're excited about contributions that expand NeMo Gym's capabilities and improv | |
| git clone [email protected]:NVIDIA-NeMo/Gym.git | ||
| cd Gym | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| source $HOME/.local/bin/env | ||
| export PATH=$HOME/.local/bin/env/bin:$PATH # or | ||
| # echo 'export PATH=$HOME/.local/bin/env/bin:$PATH' >> ~/.bashrc | ||
| uv venv --python 3.12 | ||
| source .venv/bin/activate | ||
| uv sync --extra dev --group docs | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,3 +143,7 @@ def collect_rollouts(): # pragma: no cover | |
| rch = RolloutCollectionHelper() | ||
|
|
||
| asyncio.run(rch.run_from_config(config)) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does ng_collect_rollouts not work? is the command not discoverable? why do we need this section here?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So, the entry points for scripts is mainly when we are trying to launch debug.py I was thinking and there is no harm on also giving this entry point, is there? |
||
| collect_rollouts() | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we avoid this temporary environment variable export? and also why did the source not work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the issue here is that for the newest version of uv, they changed the way the tool is installed, now I don't see a
$HOME/.local/bin/envanymore, instead the tool is installed as uv and uvx in/home/ffrujeri/.local/bin/