fix: pass dragHandleMenu prop to DragHandleButton #2254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maqen is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
nperez0111
reviewed
Dec 10, 2025
| <> | ||
| <AddBlockButton /> | ||
| <DragHandleButton /> | ||
| <DragHandleButton dragHandleMenu={props.dragHandleMenu} /> |
Contributor
There was a problem hiding this comment.
@matthewlipski I see you made a comment here about this which may be related?
Collaborator
There was a problem hiding this comment.
Ah, this comment is just about a minor typing issue. Ideally, if you pass children to the SideMenu component, you shouldn't be able to pass dragHandleMenu as it won't do anything. But the change in this PR is good, fixes a regression from #2143.
Contributor
There was a problem hiding this comment.
OK, cool thanks for confirming
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Making sure to pass
dragHandleMenuprop toDragHandleButtonas expected