Skip to content

fix: pass dragHandleMenu prop to DragHandleButton #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nperez0111 merged 1 commit into from
Dec 12, 2025
Merged

fix: pass dragHandleMenu prop to DragHandleButton #2254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/components/SideMenu/SideMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const SideMenu = (props: SideMenuProps & { children?: ReactNode }) => {
{props.children || (
<>
<AddBlockButton />
<DragHandleButton />
<DragHandleButton dragHandleMenu={props.dragHandleMenu} />
Copy link
Contributor

@nperez0111 nperez0111 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewlipski I see you made a comment here about this which may be related?

BlockNote/packages/react/src/components/SideMenu/SideMenu.tsx

Line 11 in 883ab94

// TODO: props.dragHandleMenu should only be available if no children are passed

Copy link
Collaborator

@matthewlipski matthewlipski Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this comment is just about a minor typing issue. Ideally, if you pass children to the SideMenu component, you shouldn't be able to pass dragHandleMenu as it won't do anything. But the change in this PR is good, fixes a regression from #2143.

Copy link
Contributor

@nperez0111 nperez0111 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, cool thanks for confirming

</>
)}
</Components.SideMenu.Root>
Expand Down
Loading