-
Notifications
You must be signed in to change notification settings - Fork 12
feat: added missing fields to voyage search enriched #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for filtering voyages by vessel owners and time charterers in the voyage search enriched endpoint. The changes include adding new filter parameters and their exclusion counterparts to enable more granular voyage searches.
- Added four new optional parameters:
vessel_owners,vessel_owners_excluded,time_charterer, andtime_charterer_excluded - Updated documentation to describe the new parameters
- Integrated the new parameters into the API request payload
- Incremented version from 1.0.14 to 1.0.15
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vortexasdk/version.py | Bumped version to 1.0.15 to reflect the new features |
| vortexasdk/endpoints/voyages_search_enriched.py | Added vessel owner and time charterer filter parameters with their exclusion counterparts, including documentation and payload integration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| vessel_owners: A vessel owner ID, or list of vessel owners IDs to filter on. | ||
| vessel_owners_excluded: A vessel owner ID, or list of vessel owners IDs to exclude. |
Copilot
AI
Nov 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected 'owners IDs' to 'owner IDs' for grammatical consistency with other parameter descriptions.
| vessel_owners: A vessel owner ID, or list of vessel owners IDs to filter on. | |
| vessel_owners_excluded: A vessel owner ID, or list of vessel owners IDs to exclude. | |
| vessel_owners: A vessel owner ID, or list of vessel owner IDs to filter on. | |
| vessel_owners_excluded: A vessel owner ID, or list of vessel owner IDs to exclude. |
kdalkas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
RELATED TICKETS
! Do not post related PRs here, unless they are open source !
CHANGELOG
TESTS
COMMENTS