Skip to content

Conversation

@quentinmusy
Copy link
Contributor

@quentinmusy quentinmusy commented Nov 19, 2025

RELATED TICKETS

! Do not post related PRs here, unless they are open source !

CHANGELOG

  • added missing params to voyages search enriched

TESTS

  • describe your test strategy

COMMENTS

  • any other business

Copilot AI review requested due to automatic review settings November 19, 2025 14:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for filtering voyages by vessel owners and time charterers in the voyage search enriched endpoint. The changes include adding new filter parameters and their exclusion counterparts to enable more granular voyage searches.

  • Added four new optional parameters: vessel_owners, vessel_owners_excluded, time_charterer, and time_charterer_excluded
  • Updated documentation to describe the new parameters
  • Integrated the new parameters into the API request payload
  • Incremented version from 1.0.14 to 1.0.15

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
vortexasdk/version.py Bumped version to 1.0.15 to reflect the new features
vortexasdk/endpoints/voyages_search_enriched.py Added vessel owner and time charterer filter parameters with their exclusion counterparts, including documentation and payload integration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +168 to +170
vessel_owners: A vessel owner ID, or list of vessel owners IDs to filter on.
vessel_owners_excluded: A vessel owner ID, or list of vessel owners IDs to exclude.
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'owners IDs' to 'owner IDs' for grammatical consistency with other parameter descriptions.

Suggested change
vessel_owners: A vessel owner ID, or list of vessel owners IDs to filter on.
vessel_owners_excluded: A vessel owner ID, or list of vessel owners IDs to exclude.
vessel_owners: A vessel owner ID, or list of vessel owner IDs to filter on.
vessel_owners_excluded: A vessel owner ID, or list of vessel owner IDs to exclude.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@kdalkas kdalkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@quentinmusy quentinmusy merged commit d107d41 into master Nov 20, 2025
11 of 12 checks passed
@quentinmusy quentinmusy deleted the RND-17990 branch November 20, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants