Skip to content

feat: added missing fields to voyage search enriched #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quentinmusy merged 4 commits into from
Nov 20, 2025
Merged

feat: added missing fields to voyage search enriched #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89970f7
feat: added missing fields to voyage search enriched
quentinmusy Nov 19, 2025
2ca5b03
chore: added missing permissions to token
quentinmusy Nov 19, 2025
c7e3b82
chore: moved permissions up
quentinmusy Nov 19, 2025
a610b31
chore: removed print
quentinmusy Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
permissions:
actions: read
contents: read
security-events: write

strategy:
fail-fast: false
Expand Down
18 changes: 18 additions & 0 deletions vortexasdk/endpoints/voyages_search_enriched.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ def search(
vessel_risk_level_excluded: Optional[Union[str, List[str]]] = None,
has_ship_to_ship: Optional[str] = None,
has_charterer: Optional[str] = None,
vessel_owners: Optional[Union[ID, List[ID]]] = None,
vessel_owners_excluded: Optional[Union[ID, List[ID]]] = None,
time_charterer: Optional[Union[ID, List[ID]]] = None,
time_charterer_excluded: Optional[Union[ID, List[ID]]] = None,
intra_movements: Optional[str] = None,
voyage_date_range_activity: Optional[VoyageDateRangeActivity] = None,
origin_behaviour: Optional[OriginBehaviour] = None,
Expand Down Expand Up @@ -153,10 +157,18 @@ def search(

charterers_excluded: A charterer ID, or list of charterer IDs to exclude.

time_charterer: A time charterer ID, or list of time charterer IDs to filter on.

time_charterer_excluded: A time charterer ID, or list of time charterer IDs to exclude.

effective_controllers: A vessel effective controller ID, or list of vessel effective controller IDs to filter on.

effective_controllers_excluded: A effective controller ID, or list of effective controller IDs to exclude.

vessel_owners: A vessel owner ID, or list of vessel owners IDs to filter on.

vessel_owners_excluded: A vessel owner ID, or list of vessel owners IDs to exclude.
Comment on lines +168 to +170
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'owners IDs' to 'owner IDs' for grammatical consistency with other parameter descriptions.

Suggested change
vessel_owners: A vessel owner ID, or list of vessel owners IDs to filter on.
vessel_owners_excluded: A vessel owner ID, or list of vessel owners IDs to exclude.
vessel_owners: A vessel owner ID, or list of vessel owner IDs to filter on.
vessel_owners_excluded: A vessel owner ID, or list of vessel owner IDs to exclude.

Copilot uses AI. Check for mistakes.

origins: An origin ID, or list of origin IDs for all the cargoes of a voyage to filter on.

origins_excluded: An origin ID, or list of origin IDs for all the cargoes of a voyage to exclude.
Expand Down Expand Up @@ -290,7 +302,9 @@ def search(
"products": convert_to_list(products),
"latest_products": convert_to_list(latest_products),
"charterers": convert_to_list(charterers),
"time_charterer": convert_to_list(time_charterer),
"effective_controllers": convert_to_list(effective_controllers),
"vessel_owners": convert_to_list(vessel_owners),
"origins": convert_to_list(origins),
"destinations": convert_to_list(destinations),
"locations": convert_to_list(locations),
Expand Down Expand Up @@ -334,10 +348,14 @@ def search(
"latest_products_excluded": convert_to_list(
latest_products_excluded
),
"time_charterer_excluded": convert_to_list(
time_charterer_excluded
),
"charterers_excluded": convert_to_list(charterers_excluded),
"effective_controllers_excluded": convert_to_list(
effective_controllers_excluded
),
"vessel_owners_excluded": convert_to_list(vessel_owners_excluded),
"origins_excluded": convert_to_list(origins_excluded),
"destinations_excluded": convert_to_list(destinations_excluded),
"locations_excluded": convert_to_list(locations_excluded),
Expand Down
2 changes: 1 addition & 1 deletion vortexasdk/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.0.14"
__version__ = "1.0.15"
Loading