tests: Skip package installer tests on CI #6175
Conversation
Signed-off-by: Abhijat Malviya <[email protected]>
|
The module is skipped now on running pytest |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| import pytest | ||
| from testcontainers.core.container import DockerContainer | ||
|
|
||
| pytest.skip( |
There was a problem hiding this comment.
Because the module-level skip runs after imports, from testcontainers.core.container import DockerContainer (line 4) will still execute; in environments without this dependency, collection will error instead of skipping. Consider ensuring the skip occurs before optional imports so the file reliably skips when intended.
🤖 Was this useful? React with 👍 or 👎
| from testcontainers.core.container import DockerContainer | ||
|
|
||
| pytest.skip( | ||
| "These tests will only be run for the action that generates the package repository", |
There was a problem hiding this comment.
This unconditionally skips the module in all environments; if you intend these tests to run in a dedicated release workflow, they will be skipped there as well. You could gate the skip on a CI-specific condition so the tests still run when triggered by the release action.
🤖 Was this useful? React with 👍 or 👎
|
@abhijat lets wait with this. I tried to fix it here: let's see if it helps |
Package installer tests routinely fail due to throttling on docker registry.
These tests also do not make sense when run as part of CI suite, they should only be run when new releases are created. Here these tests are skipped in CI. In the next PR they will be wired to run only as part of the action which sets up the package repository.