Skip to content

tests: Skip package installer tests on CI #6175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhijat wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

tests: Skip package installer tests on CI #6175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12a31a0
tests: Skip package installer tests on CI
abhijat Dec 5, 2025
57ded08
Merge branch 'main' into abhijat/fix/package-install-skip-on-ci
abhijat Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/dragonfly/package_install_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
import pytest
from testcontainers.core.container import DockerContainer

pytest.skip(
Copy link

@augmentcode augmentcode bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the module-level skip runs after imports, from testcontainers.core.container import DockerContainer (line 4) will still execute; in environments without this dependency, collection will error instead of skipping. Consider ensuring the skip occurs before optional imports so the file reliably skips when intended.

🤖 Was this useful? React with 👍 or 👎

"These tests will only be run for the action that generates the package repository",
Copy link

@augmentcode augmentcode bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unconditionally skips the module in all environments; if you intend these tests to run in a dedicated release workflow, they will be skipped there as well. You could gate the skip on a CI-specific condition so the tests still run when triggered by the release action.

🤖 Was this useful? React with 👍 or 👎

allow_module_level=True,
)


def check(container: DockerContainer, cmd: str):
result = container.exec(cmd)
Expand Down
Loading