Wait a bit more after fetching a non-existant yet diff.#343
Open
Frankkkkk wants to merge 1 commit intodrolbr:masterfrom
Open
Wait a bit more after fetching a non-existant yet diff.#343Frankkkkk wants to merge 1 commit intodrolbr:masterfrom
Frankkkkk wants to merge 1 commit intodrolbr:masterfrom
Conversation
When applying diffs real time (database already up to date), the minutely diff will only be available after a minute. So wait at least 40 secs instead of 10; less useless load on the replication server.
Contributor
|
I'd suggest to have a configurable parameter like in #245 with default of 10 seconds as today. |
Author
|
That seems good; however I would suggest to increase the default sleep value as:
Il copy that into the other issue ;-) |
Contributor
|
A better solution is now available in #403 I'd suggest to close this one in favor of a parametrized solution, offering more flexibility. |
Author
|
In that case I would propose to change 10seconds to 40 in #403 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying diffs real time (database already up to date), the
minutely diff will only be available after a minute. So wait at least 40
secs instead of 10; less useless load on the replication server.