Skip to content

fix:Can't put a space in app name #4055 #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dvansari65 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix:Can't put a space in app name #4055 #4058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/maker/dmg/src/MakerDMG.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,15 @@ export default class MakerDMG extends MakerBase<MakerDMGConfig> {
);

await this.ensureFile(outPath);
// Escape appName and appPath by wrapping them in quotes.
// This avoids macOS treating spaces as argument separators during
// DMG creation (fixes issue #4055).
const escapedAppPath = `"${path.resolve(dir, `${appName}.app`)}"`;
const dmgConfig: ElectronInstallerDMGOptions = {
overwrite: true,
name: appName,
name: `"${appName}"`, // escaped name
...this.config,
appPath: path.resolve(dir, `${appName}.app`),
appPath: escapedAppPath, // escaped app path
out: path.dirname(outPath),
};
await createDMG(dmgConfig);
Expand Down