Unskip compiler warnings for sycl-tla #2588
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes workarounds that were previously disabling compiler warnings (-Werror=format and -Werror=unused-variable) specifically for SYCL-TLA compilation. The change enables stricter compiler checks for SYCL-TLA code by removing the flag replacement macros and their invocations.
- Removed
replace_cmake_build_flags()andrestore_cmake_build_flags()macros - Removed calls to these macros in the SYCL-TLA build configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmake/SYCLTLA.cmake | Removed macro definitions that disabled -Werror=format and -Werror=unused-variable compiler warnings |
| src/BuildOnLinux.cmake | Removed invocations of the flag replacement macros around SYCL-TLA source compilation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.