Skip to content

Unskip compiler warnings for sycl-tla #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Silv3S wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −16
Open

Unskip compiler warnings for sycl-tla #2588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fdc7c5
remove macros
Silv3S Dec 16, 2025
32980be
Leave default flags
Silv3S Dec 16, 2025
39d094e
Leave Wno-unused-variable due to external ifdefs
Silv3S Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions cmake/SYCLTLA.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,6 @@
#
# http://www.apache.org/licenses/LICENSE-2.0

macro(replace_cmake_build_flags)
set(CMAKE_C_FLAG_BK "${CMAKE_C_FLAGS}")
set(CMAKE_CXX_FLAGS_BK "${CMAKE_CXX_FLAGS}")
string(REPLACE "-Werror=format" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
string(REPLACE "-Werror=format" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
string(REPLACE "-Werror=unused-variable" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
string(REPLACE "-Werror=unused-variable" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
endmacro()

macro(restore_cmake_build_flags)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAG_BK}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS_BK}")
endmacro()

if(NOT __SYCLTLA_INCLUDED)
set(__SYCLTLA_INCLUDED TRUE)
include(FetchContent)
Expand Down
5 changes: 3 additions & 2 deletions src/BuildOnLinux.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ endif()
if(USE_SYCLTLA)
set(REPLACE_FLAGS_FOR_SYCLTLA TRUE)
set_build_flags()
replace_cmake_build_flags()
set(CMAKE_CXX_FLAGS_BK "${CMAKE_CXX_FLAGS}")
string(REPLACE "-Werror=unused-variable" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")

foreach(sycl_src ${ATen_XPU_SYCLTLA_SRCS})
get_filename_component(name ${sycl_src} NAME_WLE REALPATH)
Expand All @@ -93,7 +94,7 @@ if(USE_SYCLTLA)

set(REPLACE_FLAGS_FOR_SYCLTLA FALSE)
set_build_flags()
restore_cmake_build_flags()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS_BK}")
endif()

set(SYCL_LINK_LIBRARIES_KEYWORD)
Expand Down
Loading