Improve deploy_windows.ps1 fetching of dependencies #3612
Merged
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Install-Dependency to create a unique empty directory for unpacking the fetched zip file into, for ASIO and NSIS. This avoids having to know the top-level directory name used within the archive, which for ASIO is not consistent between versions.
5 tasks
pljones
reviewed
Jan 30, 2026
Make asiosdk or ASIO-SDK part of the version, so that URLs are correct.
pljones
approved these changes
Feb 1, 2026
ann0see
approved these changes
Feb 1, 2026
pljones
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
In
deploy-windows.ps1, updatedInstall-Dependencyto create a unique empty directory for unpacking the fetched zip file into, for ASIO and NSIS.Also updated the regex for matching the ASIO file version in
bump-dependencies.yml.CHANGELOG: Build: Improve dependency fetching for Windows builds
Context: Fixes an issue?
Fixes #3560
Replaces #3607
This avoids having to know the top-level directory name used within the archive, which for ASIO is not consistent between versions, and could not be updated by
bump-dependencies.ymlDoes this change need documentation? What needs to be documented and how?
I don't think so. It just makes the PRs generated for updating ASIO and NSIS build properly.
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Check CI works
Checklist