-
Notifications
You must be signed in to change notification settings - Fork 19
[WTF-2485]: Remove enzyme from widget generator in preparation of React 19 #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LEGIO-SEXTA-FERRATA
wants to merge
8
commits into
master
Choose a base branch
from
WTF-2273-remove-enzyme
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4a81c3e
Replace Enzyme with RTL
LEGIO-SEXTA-FERRATA 66fbe7d
Adjust generator tests
LEGIO-SEXTA-FERRATA e413267
Bonus fix: update the year in copyright statement
LEGIO-SEXTA-FERRATA 5c6c594
Remove enzyme commands
alihcsumer 77dcc7b
Update the change log
alihcsumer fb1d082
Review: Refactor messages
alihcsumer c39ff24
Review: Update the changelog
alihcsumer 6ef55e0
Review: Update enzyme detector
alihcsumer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 7 additions & 9 deletions
16
...ates/pluggable/web/emptyTemplateJs/src/components/__tests__/HelloWorldSample.spec.jsx.ejs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,19 @@ | ||
| import { createElement } from "react"; | ||
| import { shallow } from "enzyme"; | ||
| import { render } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; | ||
|
|
||
| import { HelloWorldSample } from "../HelloWorldSample"; | ||
|
|
||
| describe("HelloWorldSample", () => { | ||
| const createHelloWorld = (props) => shallow(<HelloWorldSample {...props} />); | ||
|
|
||
| it("should render the structure correctly", () => { | ||
| const helloWorldProps = { | ||
| sampleText: "World" | ||
| }; | ||
| const helloWorld = createHelloWorld(helloWorldProps); | ||
|
|
||
| expect( | ||
| helloWorld.equals( | ||
| <div className="widget-hello-world">Hello {helloWorldProps.sampleText}</div> | ||
| ) | ||
| ).toEqual(true); | ||
| const { container } = render(<HelloWorldSample {...helloWorldProps} />); | ||
|
|
||
| const helloWorld = container.querySelector(".widget-hello-world"); | ||
| expect(helloWorld).toBeInTheDocument(); | ||
| expect(helloWorld).toHaveTextContent(`Hello ${helloWorldProps.sampleText}`); | ||
| }); | ||
| }); |
16 changes: 7 additions & 9 deletions
16
...es/pluggable/web/emptyTemplateJsFn/src/components/__tests__/HelloWorldSample.spec.jsx.ejs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,19 @@ | ||
| import { createElement } from "react"; | ||
| import { shallow } from "enzyme"; | ||
| import { render } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; | ||
|
|
||
| import { HelloWorldSample } from "../HelloWorldSample"; | ||
|
|
||
| describe("HelloWorldSample", () => { | ||
| const createHelloWorld = (props) => shallow(<HelloWorldSample {...props} />); | ||
|
|
||
| it("should render the structure correctly", () => { | ||
| const helloWorldProps = { | ||
| sampleText: "World" | ||
| }; | ||
| const helloWorld = createHelloWorld(helloWorldProps); | ||
|
|
||
| expect( | ||
| helloWorld.equals( | ||
| <div className="widget-hello-world">Hello {helloWorldProps.sampleText}</div> | ||
| ) | ||
| ).toEqual(true); | ||
| const { container } = render(<HelloWorldSample {...helloWorldProps} />); | ||
|
|
||
| const helloWorld = container.querySelector(".widget-hello-world"); | ||
| expect(helloWorld).toBeInTheDocument(); | ||
| expect(helloWorld).toHaveTextContent(`Hello ${helloWorldProps.sampleText}`); | ||
| }); | ||
| }); |
15 changes: 6 additions & 9 deletions
15
...ates/pluggable/web/emptyTemplateTs/src/components/__tests__/HelloWorldSample.spec.tsx.ejs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,19 @@ | ||
| import { createElement } from "react"; | ||
| import { shallow, ShallowWrapper } from "enzyme"; | ||
| import { render } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; | ||
|
|
||
| import { HelloWorldSample, HelloWorldSampleProps } from "../HelloWorldSample"; | ||
|
|
||
| describe("HelloWorldSample", () => { | ||
| const createHelloWorld = (props: HelloWorldSampleProps): ShallowWrapper => shallow(<HelloWorldSample {...props} />); | ||
|
|
||
| it("should render the structure correctly", () => { | ||
| const helloWorldProps: HelloWorldSampleProps = { | ||
| sampleText: "World" | ||
| }; | ||
|
|
||
| const helloWorld = createHelloWorld(helloWorldProps); | ||
| const { container } = render(<HelloWorldSample {...helloWorldProps} />); | ||
|
|
||
| expect( | ||
| helloWorld.equals( | ||
| <div className="widget-hello-world">Hello {helloWorldProps.sampleText}</div> | ||
| ) | ||
| ).toEqual(true); | ||
| const helloWorld = container.querySelector(".widget-hello-world"); | ||
| expect(helloWorld).toBeInTheDocument(); | ||
| expect(helloWorld).toHaveTextContent(`Hello ${helloWorldProps.sampleText}`); | ||
| }); | ||
| }); |
15 changes: 6 additions & 9 deletions
15
...es/pluggable/web/emptyTemplateTsFn/src/components/__tests__/HelloWorldSample.spec.tsx.ejs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,19 @@ | ||
| import { createElement } from "react"; | ||
| import { shallow, ShallowWrapper } from "enzyme"; | ||
| import { render } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; | ||
|
|
||
| import { HelloWorldSample, HelloWorldSampleProps } from "../HelloWorldSample"; | ||
|
|
||
| describe("HelloWorldSample", () => { | ||
| const createHelloWorld = (props: HelloWorldSampleProps): ShallowWrapper => shallow(<HelloWorldSample {...props} />); | ||
|
|
||
| it("should render the structure correctly", () => { | ||
| const helloWorldProps: HelloWorldSampleProps = { | ||
| sampleText: "World" | ||
| }; | ||
|
|
||
| const helloWorld = createHelloWorld(helloWorldProps); | ||
| const { container } = render(<HelloWorldSample {...helloWorldProps} />); | ||
|
|
||
| expect( | ||
| helloWorld.equals( | ||
| <div className="widget-hello-world">Hello {helloWorldProps.sampleText}</div> | ||
| ) | ||
| ).toEqual(true); | ||
| const helloWorld = container.querySelector(".widget-hello-world"); | ||
| expect(helloWorld).toBeInTheDocument(); | ||
| expect(helloWorld).toHaveTextContent(`Hello ${helloWorldProps.sampleText}`); | ||
| }); | ||
| }); |
4 changes: 1 addition & 3 deletions
4
...enerators/app/templates/pluggable/web/fullTemplateJs/src/WidgetName.editorPreview.jsx.ejs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...rator-widget/generators/app/templates/pluggable/web/fullTemplateJs/src/WidgetName.jsx.ejs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...widget/generators/app/templates/pluggable/web/fullTemplateJs/src/components/Alert.jsx.ejs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we forget to remove this with an earlier story?