[WTF-2485]: Remove enzyme from widget generator in preparation of React 19 #156

LEGIO-SEXTA-FERRATA · 2025-11-28T15:06:28Z

Checklist

Contains unit tests ✅
Contains breaking changes ✅
Compatible with: MX 1️⃣1️⃣
Did you update version and changelog? ❌
PR title properly formatted ([XX-000]: description)? ✅

This PR contains

What is the purpose of this PR?

This PR prepares the Yeoman widget generator for replacing the Enzyme for testing in favor of RTL, the React Testing Library.

Relevant changes

The generator for web package.json is adjusted to remove enzyme as a dependency
The react-dom dependency is added to resolutions and overrides as RTL required it
The scaffolded unit tests when the user chooses the unit test option are adjusted for RTL
Generator tests are adjusted
A bonus fix for updating the copyright year is included.

What should be covered while testing?

Both the options with unit test and e2e should be tested
The generator tests must be green
The default tests that arrive with a scaffolded widget should be green

REMAINING:

Check native
Check e2e tests
PWT Workflow Actions seems to be failing for the PR
One issue is that, the scaffolded widget is not able to run the unit tests before npm install is run
Check if we can get rid of the non-enzyme config in PWT
Add a check in PWT to detect and warn on enzyme tests (grepping on enzyme imports will do probably)
Mention as breaking change in release notes
Check docs

...mplates/pluggable/web/emptyTemplateTs/src/components/__tests__/HelloWorldSample.spec.tsx.ejs

weirdwater · 2025-12-09T16:18:34Z

packages/generator-widget/generators/app/lib/prompttexts.js

            name: "copyright",
            message: "Add a copyright",
-            default: "© Mendix Technology BV 2022. All rights reserved.",
+            default: "© Mendix Technology BV 2025. All rights reserved.",


weirdwater · 2025-12-09T16:27:20Z

packages/pluggable-widgets-tools/src/utils/enzyme-detector.ts

To me it would be great if we could implement this as a Typescript file. It would need to be part of the src directory and the mx-scripts file should import it from the dist directory.

weirdwater · 2025-12-09T16:28:52Z

packages/pluggable-widgets-tools/src/utils/enzyme-detector.ts

+                    }
+                }
+            }
+        } catch (error) {


I would like to see an error logged here. Even if it is just for us to debug.

weirdwater · 2025-12-09T16:30:05Z

packages/pluggable-widgets-tools/utils/enzyme-detector.js

+                        /from\s+['"]enzyme['"]/.test(content) ||
+                        /require\s*\(\s*['"]enzyme['"]\s*\)/.test(content) ||
+                        /import\s+.*\s+from\s+['"]enzyme['"]/.test(content) ||
+                        /shallow|mount|render/.test(content) && /enzyme/.test(content)


Can we describe this as a single, or less regexes? This seems to be performing a lot of scans of the same text

weirdwater · 2025-12-09T16:31:03Z

packages/pluggable-widgets-tools/utils/enzyme-detector.js

+                    scanDirectory(fullPath);
+                } else if (
+                    stat.isFile() &&
+                    (entry.endsWith(".js") ||


We can limit this to just spec files or files in test directories.

weirdwater · 2025-12-09T16:34:16Z

packages/pluggable-widgets-tools/bin/mx-scripts.js

            return `jest --projects "${join(toolsRoot, "test-config/jest.config.js")}"`;
        case "test:unit:native":
            return `jest --projects "${join(toolsRoot, "test-config/jest.native.config.js")}"`;
-        case "test:unit:web:enzyme-free":


I would move this down to the removed commands -- or fall back to the test:unit:web command

weirdwater · 2025-12-09T16:34:53Z

...ator-widget/generators/app/templates/packages/__tests__/outputs/package_web.json-js-e2e.json

  },
  "resolutions": {
    "react": "^18.2.0",
+    "react-dom": "18.2.0",


Is it necessary to add react-dom here?

weirdwater · 2025-12-09T16:35:19Z

...widget/generators/app/templates/packages/__tests__/outputs/package_web.json-js-unit-e2e.json

    "lint": "pluggable-widgets-tools lint",
    "lint:fix": "pluggable-widgets-tools lint:fix",
-    "test": "pluggable-widgets-tools test:unit:web --no-cache --ci && npm run test:e2e",
-    "test:unit": "pluggable-widgets-tools test:unit:web --coverage",


Did we forget to remove this with an earlier story?

weirdwater · 2025-12-09T16:38:04Z

packages/pluggable-widgets-tools/CHANGELOG.md


+### Breaking changes
+
+-   We removed Enzyme testing library and associated dependencies from pluggable-widgets-tools. Tests using Enzyme should be updated to use React Testing Library. See the [migration guide](https://testing-library.com/docs/react-testing-library/migrate-from-enzyme) for more information.


Maybe also announce to update the command used from test:unit:web:enzyme to test:unit:web

weirdwater · 2025-12-10T09:54:20Z

packages/pluggable-widgets-tools/src/utils/enzyme-detector.ts

We can look into implementing this as a custom eslint rule. The benefits would be:

Developers get the warnings/errors right in the editor

ESlint provides api's for analyzing the AST, which would allow us to specifically find methods imported from enzyme libraries.

If a developer chooses, they can surpress that specific rule and continue using enzyme.

LEGIO-SEXTA-FERRATA added 2 commits November 28, 2025 15:52

Replace Enzyme with RTL

4a81c3e

Adjust generator tests

66fbe7d

LEGIO-SEXTA-FERRATA requested a review from a team as a code owner November 28, 2025 15:06

mendix-widgets-framework added the generator-widget label Nov 28, 2025

alihcsumer reviewed Dec 2, 2025

View reviewed changes

...mplates/pluggable/web/emptyTemplateTs/src/components/__tests__/HelloWorldSample.spec.tsx.ejs Show resolved Hide resolved

alihcsumer force-pushed the WTF-2273-remove-enzyme branch 2 times, most recently from 33ed431 to eaab3ca Compare December 3, 2025 15:45

Bonus fix: update the year in copyright statement

e413267

alihcsumer force-pushed the WTF-2273-remove-enzyme branch from eaab3ca to e413267 Compare December 3, 2025 22:11

mendix-widgets-framework added the pluggable-widgets-tools label Dec 3, 2025

alihcsumer force-pushed the WTF-2273-remove-enzyme branch from be91f9e to ba40f08 Compare December 4, 2025 13:17

Remove enzyme commands

5c6c594

alihcsumer force-pushed the WTF-2273-remove-enzyme branch from ba40f08 to 5c6c594 Compare December 4, 2025 14:45

Update the change log

77dcc7b

weirdwater requested changes Dec 10, 2025

View reviewed changes

alihcsumer added 3 commits December 10, 2025 15:58

Review: Refactor messages

fb1d082

Review: Update the changelog

c39ff24

Review: Update enzyme detector

6ef55e0

alihcsumer force-pushed the WTF-2273-remove-enzyme branch from 3dc1e92 to 6ef55e0 Compare December 10, 2025 14:58

alihcsumer requested a review from weirdwater December 10, 2025 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WTF-2485]: Remove enzyme from widget generator in preparation of React 19 #156

[WTF-2485]: Remove enzyme from widget generator in preparation of React 19 #156

Uh oh!

LEGIO-SEXTA-FERRATA commented Nov 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

weirdwater Dec 9, 2025

Uh oh!

weirdwater Dec 9, 2025

Uh oh!

weirdwater Dec 9, 2025

Uh oh!

weirdwater Dec 9, 2025

Uh oh!

weirdwater Dec 9, 2025

Uh oh!

weirdwater Dec 9, 2025

Uh oh!

weirdwater Dec 9, 2025

Uh oh!

weirdwater Dec 9, 2025

Uh oh!

weirdwater Dec 9, 2025

Uh oh!

weirdwater Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		### Breaking changes

		- We removed Enzyme testing library and associated dependencies from pluggable-widgets-tools. Tests using Enzyme should be updated to use React Testing Library. See the [migration guide](https://testing-library.com/docs/react-testing-library/migrate-from-enzyme) for more information.

[WTF-2485]: Remove enzyme from widget generator in preparation of React 19 #156

Are you sure you want to change the base?

[WTF-2485]: Remove enzyme from widget generator in preparation of React 19 #156

Uh oh!

Conversation

LEGIO-SEXTA-FERRATA commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

This PR contains

What is the purpose of this PR?

Relevant changes

What should be covered while testing?

REMAINING:

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

LEGIO-SEXTA-FERRATA commented Nov 28, 2025 •

edited

Loading