-
Notifications
You must be signed in to change notification settings - Fork 310
Move Command and IAreaSetup types to Microsoft.Mcp.Core #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the MCP codebase by moving core command and area setup types from Azure.Mcp.Core to Microsoft.Mcp.Core, improving the separation of platform-agnostic and Azure-specific functionality.
Key Changes
- Moved
IAreaSetup,CommandGroup,BaseCommand, and related command types fromAzure.Mcp.Core.CommandstoMicrosoft.Mcp.Core.Commands - Moved
CommandContext,CommandResponse, andCommandInfofromAzure.Mcp.Core.Models.CommandtoMicrosoft.Mcp.Core.Models.Command - Extracted Azure-specific telemetry constants (
SubscriptionGuid,ResourceHash) into a separateAzureTagNameclass while moving common telemetry constants toMicrosoft.Mcp.Core.Commands
Reviewed changes
Copilot reviewed 300 out of 405 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
core/Microsoft.Mcp.Core/src/Commands/*.cs |
New location for core command types and interfaces |
core/Microsoft.Mcp.Core/src/Models/Command/*.cs |
New location for command model types |
core/Microsoft.Mcp.Core/src/Areas/IAreaSetup.cs |
Moved area setup interface to Microsoft.Mcp.Core |
core/Azure.Mcp.Core/src/Services/Telemetry/*.cs |
Split telemetry constants between Azure-specific and common |
tools/**/src/**/*.cs |
Updated imports to use Microsoft.Mcp.Core namespaces |
servers/**/src/Program.cs |
Updated imports in server entry points |
core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/SingleProxyToolLoader.cs
Outdated
Show resolved
Hide resolved
7ee723f to
ac1ede4
Compare
…e migration (#1319) * Update namespaces to Microsoft.Mcp.Core * Initial plan * Fix XML doc namespace for IAreaSetup and update new-command.md using statements Co-authored-by: hallipr <[email protected]> * Fix XML doc namespace and update new-command.md for Microsoft.Mcp.Core migration Co-authored-by: hallipr <[email protected]> --------- Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hallipr <[email protected]>
Removed the empty ItemGroup for Exceptions folder.
What does this PR do?
Moves more types from Azure.Mcp.Core into Microsoft.Mcp.Core
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.md.\eng\scripts\Update-AzCommandsMetadata.ps1to update tool metadata in azmcp-commands.md (required for CI)ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.json/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline