Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 4, 2025

What does this PR do?

Completes namespace migration follow-up from #1318 for XML documentation and developer guidance. This PR addresses only the XML documentation and markdown documentation updates, excluding tool file using statement changes which are now handled in the base PR.

Changes

  • XML Documentation: Added full namespace qualifiers in SingleProxyToolLoader.cs to fix documentation generation and IDE tooling support:

    • Microsoft.Mcp.Core.Commands.IBaseCommand
    • Microsoft.Mcp.Core.Areas.IAreaSetup
  • Developer Documentation: Updated new-command.md using statement examples to reflect the namespace migration:

    • Base command examples now use using Microsoft.Mcp.Core.Commands;
    • Troubleshooting guidance updated for TrimAnnotations.CommandAnnotations
    • Minimal using statement examples reordered for consistency

Example

// Before (incorrect after namespace migration)
using Azure.Mcp.Core.Commands;
using Azure.Mcp.Core.Commands.Subscription;

// After (correct)
using Azure.Mcp.Core.Commands.Subscription;
using Microsoft.Mcp.Core.Commands;

Note: Azure.Mcp.Core.Commands.Subscription correctly remains in the Azure namespace.

GitHub issue number?

Related to #1318

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update documentation for Command and IAreaSetup types Fix XML doc namespace and update new-command.md for Microsoft.Mcp.Core migration Dec 4, 2025
Copilot AI requested a review from hallipr December 4, 2025 23:10
Copilot finished work on behalf of hallipr December 4, 2025 23:10
@hallipr hallipr force-pushed the users/pahallis/core-migration branch from 7ee723f to ac1ede4 Compare December 5, 2025 00:04
@hallipr hallipr closed this Dec 5, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure MCP Server Dec 5, 2025
@hallipr hallipr reopened this Dec 5, 2025
@github-project-automation github-project-automation bot moved this from Done to Untriaged in Azure MCP Server Dec 5, 2025
@hallipr
Copy link
Member

hallipr commented Dec 5, 2025

@copilot, the base PR has been updated with many using statement changes. Reset this PR and redo only the xml and markdown doc changes.

Copy link
Contributor Author

Copilot AI commented Dec 5, 2025

@copilot, the base PR has been updated with many using statement changes. Reset this PR and redo only the xml and markdown doc changes.

I've reset the PR to commit 6cae57c and created a new commit (0c8d6d8) with only the XML documentation and markdown changes as requested. However, I'm unable to force push due to system constraints.

The changes are ready and committed locally:

  • XML doc: Added full namespace Microsoft.Mcp.Core.Areas.IAreaSetup and Microsoft.Mcp.Core.Commands.IBaseCommand
  • new-command.md: Updated using statements from Azure.Mcp.Core.Commands to Microsoft.Mcp.Core.Commands

No tool file using statement changes are included. The branch needs a force push to update the remote.

Copilot finished work on behalf of hallipr December 5, 2025 21:51
@hallipr hallipr marked this pull request as ready for review December 6, 2025 00:19
@hallipr hallipr requested review from a team as code owners December 6, 2025 00:19
@hallipr hallipr requested review from g2vinay and vukelich and removed request for a team December 6, 2025 00:19
@hallipr hallipr merged commit 402ef8a into users/pahallis/core-migration Dec 6, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure MCP Server Dec 6, 2025
@hallipr hallipr deleted the copilot/sub-pr-1318 branch December 6, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants