Skip to content

Fix XML doc namespace and update new-command.md for Microsoft.Mcp.Core migration #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hallipr merged 5 commits into from
Dec 6, 2025
+4 −5
Merged

Fix XML doc namespace and update new-command.md for Microsoft.Mcp.Core migration #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ee723f
Update namespaces to Microsoft.Mcp.Core
hallipr Dec 4, 2025
d1ad41c
Initial plan
Copilot Dec 4, 2025
bdd7719
Fix XML doc namespace for IAreaSetup and update new-command.md using …
Copilot Dec 4, 2025
b2d86b6
Fix XML doc namespace and update new-command.md for Microsoft.Mcp.Cor…
Copilot Dec 5, 2025
7e4e31b
Merge branch 'users/pahallis/core-migration' into copilot/sub-pr-1318
hallipr Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/SingleProxyToolLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ private async Task<string> GetRootToolsJsonAsync(CancellationToken cancellationT
}

/// <summary>
/// Gets the set of <see cref="Microsoft.Mcp.Core.Commands.IBaseCommand"/> within an <see cref="IAreaSetup">.
/// Gets the set of <see cref="Microsoft.Mcp.Core.Commands.IBaseCommand"/> within an <see cref="Microsoft.Mcp.Core.Areas.IAreaSetup">.
/// </summary>
/// <param name="request">Calling request</param>
/// <param name="tool">Name of the <see cref="IAreaSetup"/> to get commands for.</param>
Expand Down
7 changes: 3 additions & 4 deletions servers/Azure.Mcp.Server/docs/new-command.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,11 +839,11 @@ Each toolset has its own hierarchy of base command classes that inherit from `Gl
// Licensed under the MIT License.

using System.Diagnostics.CodeAnalysis;
using Azure.Mcp.Core.Commands;
using Azure.Mcp.Core.Commands.Subscription;
using Azure.Mcp.Core.Extensions;
using Azure.Mcp.Core.Models.Option;
using Azure.Mcp.Tools.{Toolset}.Options;
using Microsoft.Mcp.Core.Commands;

namespace Azure.Mcp.Tools.{Toolset}.Commands;

Expand Down Expand Up @@ -1625,9 +1625,8 @@ When creating new C# files, start with only the using statements you actually ne

```csharp
// Start minimal - only add what you actually use
using Azure.Mcp.Core.Commands;
using Microsoft.Extensions.Logging;
using Microsoft.Mcp.Core.Models.Command;
using Microsoft.Mcp.Core.Commands;

// Add more using statements as you implement the code
// Don't copy-paste using blocks from other files
Expand Down Expand Up @@ -2177,7 +2176,7 @@ var subscriptionResource = armClient.GetSubscriptionResource(new ResourceIdentif
- **Solution**: Use correct generic type: `ILogger<BaseDatabaseCommand<TOptions>>`

**Issue: Missing using statements for TrimAnnotations**
- **Solution**: Add `using Azure.Mcp.Core.Commands;` for `TrimAnnotations.CommandAnnotations`
- **Solution**: Add `using Microsoft.Mcp.Core.Commands;` for `TrimAnnotations.CommandAnnotations`

### AOT Compilation Issues

Expand Down