Skip to content

Conversation

@tedxu
Copy link
Contributor

@tedxu tedxu commented Dec 9, 2025

See #46211

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 9, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Dec 9, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Dec 9, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 83.56164% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.01%. Comparing base (d7050c4) to head (35c6bb7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...re/storagev2translator/ManifestGroupTranslator.cpp 6.89% 27 Missing ⚠️
...egcore/storagev2translator/AggregateTranslator.cpp 90.78% 7 Missing ⚠️
...re/storagev2translator/AggregateTranslatorTest.cpp 96.06% 7 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 5 Missing ⚠️
.../segcore/storagev2translator/AggregateTranslator.h 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #46212       +/-   ##
===========================================
- Coverage   82.73%   76.01%    -6.73%     
===========================================
  Files         526     1897     +1371     
  Lines       82814   296763   +213949     
===========================================
+ Hits        68520   225594   +157074     
- Misses      14294    63700    +49406     
- Partials        0     7469     +7469     
Components Coverage Δ
Client 78.17% <ø> (∅)
Core 82.80% <83.56%> (+0.06%) ⬆️
Go 74.03% <ø> (∅)
Files with missing lines Coverage Δ
...core/storagev2translator/ManifestGroupTranslator.h 11.11% <100.00%> (+11.11%) ⬆️
.../segcore/storagev2translator/AggregateTranslator.h 33.33% <33.33%> (ø)
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 58.73% <0.00%> (-0.12%) ⬇️
...egcore/storagev2translator/AggregateTranslator.cpp 90.78% <90.78%> (ø)
...re/storagev2translator/AggregateTranslatorTest.cpp 96.06% <96.06%> (ø)
...re/storagev2translator/ManifestGroupTranslator.cpp 35.34% <6.89%> (+35.34%) ⬆️

... and 1368 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tedxu tedxu force-pushed the feat/aggregate_translator branch from 03d7bf5 to 35c6bb7 Compare December 9, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants