fix: Don't try to fetch table metadata when updating query schema #8598
+0
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A change made in #8486 is resulting in the dryrun cloud function always trying to fetch table metadata when updating query schemas, but during deploys to stage the tables don't exist, so deploying ETLs without
schema.yamlfiles to stage is now consistently failing (e.g. theevents_stream_v1ETLs, which is blocking #8596).As a quick fix this undoes the problematic change, though that might break some of the caching speed improvements implemented in #8486 (cc @scholtzan).
An alternate solution could be to update the dryrun cloud function to either not try to fetch the table metadata when a query is being passed in, or not fail the entire function call due to a table metadata fetch error if a query is being passed in.
Related Tickets & Documents
document_event_numbercolumn toevents_stream_v1tables andevent_idcolumn toevents_streamviews (DENG-9800) #8596Reviewer, please follow this checklist