OCPBUGS-74508: Remove GatewayAPI featuregates#2742
OCPBUGS-74508: Remove GatewayAPI featuregates#2742rhamini3 wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Hello @rhamini3! Some important instructions when contributing to openshift/api: |
openshift-ci-robot
added
jira/valid-reference
|
@rhamini3: This pull request references Jira Issue OCPBUGS-74508, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
Review Summary by QodoRemove GatewayAPI and GatewayAPIController feature gates
WalkthroughsDescription• Remove GatewayAPI and GatewayAPIController feature gate definitions • Delete legacy feature gate entries from configuration files • Update feature gate documentation and manifest files • Clean up feature gate references across multiple deployment profiles Diagramflowchart LR
FG["Feature Gate Definitions"]
LFG["Legacy Feature Gates"]
DOC["Documentation & Manifests"]
REMOVED["GatewayAPI & GatewayAPIController Removed"]
FG -- "Delete gate definitions" --> REMOVED
LFG -- "Remove legacy entries" --> REMOVED
DOC -- "Update references" --> REMOVED
File Changes1. features/features.go
|
Code Review by Qodo
1. Dropped gates from status lists
|
📝 WalkthroughWalkthroughThis pull request removes the GatewayAPI and GatewayAPIController feature gates from the codebase. Changes include deletion of feature gate definitions from features.go, removal of entries from legacy feature gate sets in multiple files, and removal of GatewayAPI and GatewayAPIController from enabled lists across all feature gate configuration manifests covering different cluster profiles (Hypershift and SelfManagedHA variants with Default, DevPreviewNoUpgrade, OKD, and TechPreviewNoUpgrade readiness levels). 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| { | ||
| "name": "GCPClusterHostedDNSInstall" | ||
| }, | ||
| { |
There was a problem hiding this comment.
1. Dropped gates from status lists 🐞 Bug ⛯ Reliability
Removing GatewayAPI/GatewayAPIController from the rendered FeatureGate payload manifests means they will no longer appear in FeatureGate.status.featureGates. Since the API explicitly requires operators (other than CVO/CCO) to read .status.featureGates and make operands match, any remaining consumer that expects these gates can silently change behavior or fail after upgrade when the gates disappear.
Agent Prompt
## Issue description
The PR removes `GatewayAPI` and `GatewayAPIController` from the rendered FeatureGate payload manifests. Per the FeatureGate API contract, operators read `.status.featureGates` to drive operand/operator behavior. If any consumers still look up these names, they may misbehave or fail after upgrade.
## Issue Context
Payload featuregate YAMLs are rendered from `features.AllFeatureSets()` by the render command, and become the canonical `.status.featureGates` list.
## Fix Focus Areas
- payload-command/render/write_featureset.go[172-240]
- payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml[284-304]
- config/v1/types_feature.go[110-121]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
rhamini3
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Tested it with 4.22.0-0-2026-03-05-051128-test-ci-ln-4m5zfnt-latest |
|
/lgtm |
openshift-ci-robot
added
the
verified
|
@JoelSpeed: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Scheduling tests matching the |
|
/hold we need openshift/cluster-ingress-operator#1366 merged first |
openshift-ci
bot
added
the
do-not-merge/hold
|
@rhamini3: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
5 participants
API PR to remove featuregates for gatewayAPI and gatewayAPIController