Skip to content

OCPBUGS-74508: Remove GatewayAPI featuregates #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhamini3 wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −75
Open

OCPBUGS-74508: Remove GatewayAPI featuregates #2742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,6 @@
| ExternalOIDC| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ExternalOIDCWithUIDAndExtraClaimMappings| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| GCPClusterHostedDNSInstall| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| GatewayAPI| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| GatewayAPIController| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| HighlyAvailableArbiter| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ImageStreamImportMode| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ImageVolume| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down
21 changes: 0 additions & 21 deletions features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,6 @@ var (
enable(inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
mustRegister()

FeatureGateGatewayAPI = newFeatureGate("GatewayAPI").
reportProblemsToJiraComponent("Routing").
contactPerson("miciah").
productScope(ocpSpecific).
enhancementPR(legacyFeatureGateWithoutEnhancement).
enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
mustRegister()

FeatureGateOpenShiftPodSecurityAdmission = newFeatureGate("OpenShiftPodSecurityAdmission").
reportProblemsToJiraComponent("auth").
contactPerson("ibihim").
Expand Down Expand Up @@ -778,19 +770,6 @@ var (
enable(inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
mustRegister()

FeatureGateGatewayAPIController = newFeatureGate("GatewayAPIController").
reportProblemsToJiraComponent("Routing").
contactPerson("miciah").
productScope(ocpSpecific).
// Previously, the "GatewayAPI" feature gate managed both the GatewayAPI CRDs
// and the Gateway Controller. However, with the introduction of Gateway CRD
// lifecycle management (EP#1756), these responsibilities were separated.
// A dedicated feature gate now controls the Gateway Controller to distinguish
// its production readiness from that of the CRDs.
enhancementPR("https://github.com/openshift/enhancements/pull/1756").
enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
mustRegister()

FeatureShortCertRotation = newFeatureGate("ShortCertRotation").
reportProblemsToJiraComponent("kube-apiserver").
contactPerson("vrutkovs").
Expand Down
2 changes: 0 additions & 2 deletions features/legacyfeaturegates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ var legacyFeatureGates = sets.New(
// never add to this list, if you think you have an exception ask @deads2k
"GCPClusterHostedDNS",
// never add to this list, if you think you have an exception ask @deads2k
"GatewayAPI",
// never add to this list, if you think you have an exception ask @deads2k
"HardwareSpeed",
// never add to this list, if you think you have an exception ask @deads2k
"ImageStreamImportMode",
Expand Down
2 changes: 0 additions & 2 deletions payload-command/render/legacyfeaturegates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ var legacyFeatureGates = sets.New(
// never add to this list, if you think you have an exception ask @deads2k
"GCPClusterHostedDNS",
// never add to this list, if you think you have an exception ask @deads2k
"GatewayAPI",
// never add to this list, if you think you have an exception ask @deads2k
"HardwareSpeed",
// never add to this list, if you think you have an exception ask @deads2k
"ImageStreamImportMode",
Expand Down
6 changes: 0 additions & 6 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,12 +292,6 @@
{
"name": "GCPClusterHostedDNSInstall"
},
{
Copy link

@qodo-code-review qodo-code-review bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Dropped gates from status lists 🐞 Bug ⛯ Reliability

Removing GatewayAPI/GatewayAPIController from the rendered FeatureGate payload manifests means they
will no longer appear in FeatureGate.status.featureGates. Since the API explicitly requires
operators (other than CVO/CCO) to read .status.featureGates and make operands match, any remaining
consumer that expects these gates can silently change behavior or fail after upgrade when the gates
disappear.
Agent Prompt 
## Issue description
The PR removes `GatewayAPI` and `GatewayAPIController` from the rendered FeatureGate payload manifests. Per the FeatureGate API contract, operators read `.status.featureGates` to drive operand/operator behavior. If any consumers still look up these names, they may misbehave or fail after upgrade.

## Issue Context
Payload featuregate YAMLs are rendered from `features.AllFeatureSets()` by the render command, and become the canonical `.status.featureGates` list.

## Fix Focus Areas
- payload-command/render/write_featureset.go[172-240]
- payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml[284-304]
- config/v1/types_feature.go[110-121]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

"name": "GatewayAPI"
},
{
"name": "GatewayAPIController"
},
{
"name": "HighlyAvailableArbiter"
},
Expand Down
6 changes: 0 additions & 6 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,6 @@
{
"name": "GCPDualStackInstall"
},
{
"name": "GatewayAPI"
},
{
"name": "GatewayAPIController"
},
{
"name": "GatewayAPIWithoutOLM"
},
Expand Down
6 changes: 0 additions & 6 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,12 +294,6 @@
{
"name": "GCPClusterHostedDNSInstall"
},
{
"name": "GatewayAPI"
},
{
"name": "GatewayAPIController"
},
{
"name": "HighlyAvailableArbiter"
},
Expand Down
6 changes: 0 additions & 6 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,6 @@
{
"name": "GCPDualStackInstall"
},
{
"name": "GatewayAPI"
},
{
"name": "GatewayAPIController"
},
{
"name": "GatewayAPIWithoutOLM"
},
Expand Down
6 changes: 0 additions & 6 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,12 +286,6 @@
{
"name": "GCPClusterHostedDNSInstall"
},
{
"name": "GatewayAPI"
},
{
"name": "GatewayAPIController"
},
{
"name": "HighlyAvailableArbiter"
},
Expand Down
6 changes: 0 additions & 6 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,12 +198,6 @@
{
"name": "GCPDualStackInstall"
},
{
"name": "GatewayAPI"
},
{
"name": "GatewayAPIController"
},
{
"name": "GatewayAPIWithoutOLM"
},
Expand Down
6 changes: 0 additions & 6 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,12 +288,6 @@
{
"name": "GCPClusterHostedDNSInstall"
},
{
"name": "GatewayAPI"
},
{
"name": "GatewayAPIController"
},
{
"name": "HighlyAvailableArbiter"
},
Expand Down
6 changes: 0 additions & 6 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,6 @@
{
"name": "GCPDualStackInstall"
},
{
"name": "GatewayAPI"
},
{
"name": "GatewayAPIController"
},
{
"name": "GatewayAPIWithoutOLM"
},
Expand Down