-
Notifications
You must be signed in to change notification settings - Fork 149
Issue #1068: migrate to checkstyle 11.0.0 #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Issue #1068: migrate to checkstyle 11.0.0 #1075
Conversation
d911d47 to
79db5d8
Compare
|
Conflict |
f2e2685 to
93b9096
Compare
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
items to clarify
| <version>1.44.1</version> | ||
| </parent> | ||
|
|
||
| <groupId>com.github.sevntu-checkstyle</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this requied?
| <checkstyle.header>https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java.header</checkstyle.header> | ||
| <checkstyle.regexp.header>https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java-regexp.header</checkstyle.regexp.header> | ||
| <antrun.plugin.version>3.1.0</antrun.plugin.version> | ||
| <checkstyle.java.version>17</checkstyle.java.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep it, I do not remember exactly but it was usefull in some cases.
| <id>2020-09</id> | ||
| <id>eclipse-2020-09</id> | ||
| <layout>p2</layout> | ||
| <url>https://download.eclipse.org/releases/2020-09</url> | ||
| <url>https://download.eclipse.org/releases/2020-09/</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please share details on this update
| @@ -0,0 +1,144 @@ | |||
| # The list of options supported by Eclipse compiler | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this new file is required?
|
as this is major release , please read https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/SevNTU-plugin-for-EclipseCS-plugin-compilation and confirm that eclipse plugin is runnable , share sreenshot of some Check configuration that appeared recently in main plugin - PatternVariableAssignment. example how plugin maintainers are doing this checkstyle/eclipse-cs#862 |
|
eclipse-cs already migrated to checkstyle 12.X.X checkstyle/eclipse-cs#914 so we can continue migration to checkstyle 11 or 12 |
part of : #1068