Skip to content

Conversation

@AmitKumarDeoghoria
Copy link
Contributor

part of : #1068

@AmitKumarDeoghoria AmitKumarDeoghoria force-pushed the upg1 branch 2 times, most recently from d911d47 to 79db5d8 Compare August 23, 2025 13:51
@romani
Copy link
Member

romani commented Aug 23, 2025

Conflict

@AmitKumarDeoghoria AmitKumarDeoghoria force-pushed the upg1 branch 5 times, most recently from f2e2685 to 93b9096 Compare August 29, 2025 16:26
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items to clarify

<version>1.44.1</version>
</parent>

<groupId>com.github.sevntu-checkstyle</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this requied?

<checkstyle.header>https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java.header</checkstyle.header>
<checkstyle.regexp.header>https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java-regexp.header</checkstyle.regexp.header>
<antrun.plugin.version>3.1.0</antrun.plugin.version>
<checkstyle.java.version>17</checkstyle.java.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep it, I do not remember exactly but it was usefull in some cases.

Comment on lines -30 to +32
<id>2020-09</id>
<id>eclipse-2020-09</id>
<layout>p2</layout>
<url>https://download.eclipse.org/releases/2020-09</url>
<url>https://download.eclipse.org/releases/2020-09/</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please share details on this update

@@ -0,0 +1,144 @@
# The list of options supported by Eclipse compiler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this new file is required?

@romani
Copy link
Member

romani commented Sep 1, 2025

as this is major release , please read https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/SevNTU-plugin-for-EclipseCS-plugin-compilation and confirm that eclipse plugin is runnable , share sreenshot of some Check configuration that appeared recently in main plugin - PatternVariableAssignment.
and screenshot that some config/setup UI for some Check in sevntu is rendering well and can produce some violation.

example how plugin maintainers are doing this checkstyle/eclipse-cs#862

@romani
Copy link
Member

romani commented Nov 16, 2025

eclipse-cs already migrated to checkstyle 12.X.X checkstyle/eclipse-cs#914

so we can continue migration to checkstyle 11 or 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants